Hi, I wan to build a dtfm detector in c++/qt

I have found one http://aluigi.org/mytoolz/dtmf2num.zip but mine doesn't 
work. I'd like to upload the project on internet. 
Could you help me ?


Lionel - www.fulgor-it.info

Lionel VW wrote:

> I have found one http://aluigi.org/mytoolz/dtmf2num.zip but mine doesn't 
> work. I'd like to upload the project on internet. 
> Could you help me ?

You sent this to me privately as well. I didn't repsond positively
because I don't know you and simply don't have the time to help
all the random people who might send me email asking for help
(most of those people want me to send them money btw).

Even post this here is problematic because you don't specify what
exact problem you are having. You also don't specify what OS and
what tools you are using.

All round this is pretty poor form.

Erik
-- 
----------------------------------------------------------------------
Erik de Castro Lopo
http://www.mega-nerd.com/

Erik de Castro Lopo wrote:

> Lionel VW wrote:
> 
> > I have found one http://aluigi.org/mytoolz/dtmf2num.zip but mine doesn't 
> > work. I'd like to upload the project on internet. 
> > Could you help me ?
> 
> You sent this to me privately as well. I didn't repsond positively
> because I don't know you and simply don't have the time to help
> all the random people who might send me email asking for help
> (most of those people want me to send them money btw).
> 
> Even post this here is problematic because you don't specify what
> exact problem you are having. You also don't specify what OS and
> what tools you are using.
> 
> All round this is pretty poor form.

I took a look at your code. Seems like standard C and has a Makefile.
That makes it easier for me. However your C code has problems. With
you Makefile as it is I get the following errors:

  dtmf2num.c:350:9: warning: assignment makes pointer from integer without a cast
  resample2.c:224:13: warning: attempt to free a non-heap object 'c'

If I add -Wall to the CFLAGS variable in you Makefile there are well
over 100 warnings. Sorry, but I'm not going to get myself involved
with code of that quality.

Most quality C code has zero warnings with -Wall.

Erik
-- 
----------------------------------------------------------------------
Erik de Castro Lopo
http://www.mega-nerd.com/

On Fri, 05 Aug 2011 10:57:55 +1000, Erik de Castro Lopo wrote:

> Erik de Castro Lopo wrote:
> 
>> Lionel VW wrote:
>> 
>> > I have found one http://aluigi.org/mytoolz/dtmf2num.zip but mine
>> > doesn't work. I'd like to upload the project on internet. Could you
>> > help me ?
>> 
>> You sent this to me privately as well. I didn't repsond positively
>> because I don't know you and simply don't have the time to help all the
>> random people who might send me email asking for help (most of those
>> people want me to send them money btw).
>> 
>> Even post this here is problematic because you don't specify what exact
>> problem you are having. You also don't specify what OS and what tools
>> you are using.
>> 
>> All round this is pretty poor form.
> 
> I took a look at your code. Seems like standard C and has a Makefile.
> That makes it easier for me. However your C code has problems. With you
> Makefile as it is I get the following errors:
> 
>   dtmf2num.c:350:9: warning: assignment makes pointer from integer
>   without a cast resample2.c:224:13: warning: attempt to free a non-heap
>   object 'c'
> 
> If I add -Wall to the CFLAGS variable in you Makefile there are well
> over 100 warnings. Sorry, but I'm not going to get myself involved with
> code of that quality.
> 
> Most quality C code has zero warnings with -Wall.

... and some crappy code.  At least if the crappy coder knew that passing 
the '-Wall' test was a requirement.

-- 
www.wescottdesign.com

On Thu, 04 Aug 2011 18:01:59 +0000, Lionel VW wrote:

> I have found one http://aluigi.org/mytoolz/dtmf2num.zip but mine doesn't
> work. I'd like to upload the project on internet. Could you help me ?

If we knew what the symptoms were, what you're trying to do with the 
code, why you think it'll work for you, why you can't roll your own, and 
if any of the above struck a bell, someone would probably try.

But your question lacks specificity to a considerable degree.

-- 
www.wescottdesign.com

>I have found one http://aluigi.org/mytoolz/dtmf2num.zip but mine doesn't 
>work. I'd like to upload the project on internet. 
>Could you help me ?
>
>
>Lionel - www.fulgor-it.info
>

You are lucky. Vladimir has not replied yet!

On 05-08-2011 @ 02:57:55 Erik de Castro Lopo <erikd@mega-nerd.com> wrote:

(...)

>   dtmf2num.c:350:9: warning: assignment makes pointer from integer  
> without a cast

This is most popular warning and completely not big problem.
At least not worth mentioning.

> Most quality C code has zero warnings with -Wall.
>
> Erik

Really???

-- 
Mikolaj

>On 05-08-2011 @ 02:57:55 Erik de Castro Lopo <erikd@mega-nerd.com> wrote:
>
>(...)
>
>>   dtmf2num.c:350:9: warning: assignment makes pointer from integer  
>> without a cast
>
>This is most popular warning and completely not big problem.
>At least not worth mentioning.

So, you never use 64 bit machines? Its a critically important error if you
do.

>> Most quality C code has zero warnings with -Wall.
>>
>> Erik
>
>Really???

Well, not really, because -Wall doesn't do enough checking. Well designed
code uses a make file that turns on a lot more checking that -Wall provides
with GCC.

Steve

steveu wrote:

> Well, not really, because -Wall doesn't do enough checking. Well designed
> code uses a make file that turns on a lot more checking that -Wall provides
> with GCC.

+1

I normally use the following as well:

     -Wstrict-prototypes -Wmissing-prototypes -Waggregate-return
     -Wcast-align -Wcast-qual -Wnested-externs -Wshadow
     -Wbad-function-cast -Wwrite-strings -Wundef

I also try to remove all the cast operations I can because casts
can hide bugs.

Erik
-- 
----------------------------------------------------------------------
Erik de Castro Lopo
http://www.mega-nerd.com/

On Fri, 05 Aug 2011 08:48:41 +0200, Mikolaj wrote:

> On 05-08-2011 @ 02:57:55 Erik de Castro Lopo <erikd@mega-nerd.com>
> wrote:
> 
> (...)
> 
>>   dtmf2num.c:350:9: warning: assignment makes pointer from integer
>> without a cast
> 
> This is most popular warning and completely not big problem. At least
> not worth mentioning.

Maybe in _your_ code.

>> Most quality C code has zero warnings with -Wall.
>>
>> Erik
> 
> Really???

Really!!!

Code can be decent quality with some warnings, but -Wall is a pretty 
cheap way to make sure you're not making the really stupid mistakes.

-- 
www.wescottdesign.com